EHM 1 Database & Saved Game Editor v1: BUG REPORTS & FEATURE REQUESTS

[archibalduk]

Brazilian Ice Hockey League

Thanks. I'm taking a look. My suspicion is that there are duplicate UIDs caused by an older version of the Editor.

[archibalduk]

Version 0.5.2 of the EHM Editor is now available for download here: https://github.com/archibalduk/Eastside ... v0.5.2.zip

This release is a combination of (1) an assortment of features requested by various people over recent weeks and (2) a new 'Status' section of the Rules & Structures screen which shows the results of various validation checks. A full list of the current validation rules can be found HERE. Please use that thread to post any feedback/requests relating to the validation rules as it will make it easier for me to keep track of everything. The current range of validation checks is relatively narrow, but I'll add more in coming releases (ideawithoutamind has provided a lot of useful suggestions which I'll work through). Thanks to TBIF and ideawithoutamind for all of the suggestions to date (TBIF - I added a rule which should flag if you forget to add schedule dates to the second conference playoffs but let me know if it isn't picking up the error you had in mind).

Assuming no hotfix is needed in the meantime, I'm working on adding some sort of flowchart section to the Rules & Structures screen for v0.5.3. The idea is that this will show how each stage is linked with the others and hopefully identify any overlaps of dates or missing next stage triggers. I was hoping to use a third party flowchart tool but this isn't looking possible so I'll need to create my own simple version. I'm currently weighing up either over some sort of text-based "chart" or a horizontal bar chart/calendar display. I think the latter is probably the better solution. I don't know how long it will take to get a first version of this up and running and so it might be something I'll work on in the background for a later version if any hotfixes/etc for the Editor are needed in the meantime.

One last note: I tidied up some of the core functions in the Editor relating to all text and values shown in the database (i.e. the data behind pretty much editable field). The changes were very minor and I don't envisage any issues (and I didn't find any whilst testing) but let me know if you find that a value isn't importing or saving. As I say, I'm comfortable that the changes were fine but you never know given that this is just a one man amateur project!

New Features:

• Added a mass editing option on the Clubs menu to make all clubs in active where they are assigned to an inactive league;
• Added a mass editing option on the People menu to delete all player career history entries where no club or competition has been assigned;
• Added a random name option on the Players & Staff and Officials screens;
• Added copy and paste options to the Player Details and Non-Player screens and via the Tools menu on those screens;
• Added options to clear all player or non-player attributes on the Players & Staff screen; and
• Added Rules and Structures validation displayed on the Status sub-screen (see here for a full list of validation rules).

Fixes and Improvements:

• Added basic filtering options to the Rules and Structures screen;
• Added extra details to the Rules and Structures text report (date range of schedule and actual next upper and lower stages);
• Added option to ignore "C" or "A" captaincy text suffixed to club names when importing player career history spreadsheets;
• Adjusted text sorting to case insensitive;
• Fixed a bug when filtering by Player Role where Goalie: Mixed might be shown when [None] is initially selected as the chosen filter value; and
• Minor optimisations to text matching functions and a general code tidy-up for basic data types.

[xECK29x]

Added option to ignore "C" or "A" captaincy text suffixed to club names when importing player career history spreadsheets;

This doesn't appear to be working for me, using a standard modern Excel Workbook (.xlsx) file for import, doing a direct copy-paste as text from EP.

[archibalduk]

Added option to ignore "C" or "A" captaincy text suffixed to club names when importing player career history spreadsheets;

This doesn't appear to be working for me, using a standard modern Excel Workbook (.xlsx) file for import, doing a direct copy-paste as text from EP.

Stupid question, but have you checked the 'Ignore "A" & "C" in club names' setting on the Import Spreadsheet screen? Assuming you have, can you email a copy of the spreadsheet to me? It might be that there are hidden characters, etc which also need stripping from the club name.

[archibalduk]

I know I need to debug the databases from xECK29x and ideawithoutamind but I wanted to make a start on the Stage Structure Chart screen whilst it is fresh in my mind. As mentioned a few days ago, the idea is for a new tab on the Rules & Structures screen which shows a graphical representation of the stages of a playable league in order to help with understanding a structure and identifying issues. I only started work on this yesterday, but I've already made good progress - see the screenshot below.

The chart below might not look like a lot but it was automatically generated using the data from the NHL (albeit I added a sixth stage in order to test out lower stages). The horizontal axis (which will eventually have text labels) is effectively a timeline with the start of the season on the left and the end of the season on the right. The vertical axis shows the stages in numerical order - i.e. the uppermost box represents the first stage and the lowermost box represents the final stage. Initial stages are in blue, upper stages are in green and lower stages are in red. The lines show the links between stages - i.e. the stage triggers.

In the case of the structure shown in the screenshot below:

• the two blue boxes represent the two initial stages of the NHL (Western and Eastern Conferences) running from October to April;
• the middle two green boxes represent the two conference finals playoff stages running from April to May;
• the lowest green box represents the Stanley Cup finals running from May to June; and
• the red box represents a fictional lower/playouts stage just for the purposes of testing.

The next step is to add a label to the horizontal axis, text labels to the boxes representing the stages and individual boxes representing each round of a cup stage.

[batal]

Hey all,

I have problems with editing saved games. Just tried to open saved game (completely new, first day of first season) and saved it with edititor as new file without any changes.
After that I try to open this new sav file. And game just craches (without any error).

Game is 1.4.1 (latest from steam, downloaded few days ago).

I clearly remember that I've used editor few years ago and it worked fine with saved game.

Am I doing something wrong?

[xECK29x]

Hey all,

I have problems with editing saved games. Just tried to open saved game (completely new, first day of first season) and saved it with edititor as new file without any changes.
After that I try to open this new sav file. And game just craches (without any error).

Game is 1.4.1 (latest from steam, downloaded few days ago).

I clearly remember that I've used editor few years ago and it worked fine with saved game.

Am I doing something wrong?

It's not supported, a save game is not the same format as a DB, you can look around in a save game file but you cannot modify it without breaking it. For can make some simple changes in-game (think Commissioner mode in FHM, with EHM Assistant).

[xECK29x]

Stupid question, but have you checked the 'Ignore "A" & "C" in club names' setting on the Import Spreadsheet screen? Assuming you have, can you email a copy of the spreadsheet to me? It might be that there are hidden characters, etc which also need stripping from the club name.

Yes sir, that is what I think it is, will send it over!

[archibalduk]

I'm strictly a 1.4.1 user, so not sure if this carries over to 1.5 (worth verifying before doing anything extensive troubeshooting to figure it out)

This is using a modified version of PremierPivot 5.5 (I had stripped out a bunch of the playable league rules, and copied the DEL and Germany setup over to a full Brazilian setup mimicking germany, and added Brazilian players (basically copied and renamed from German players)
Figured xECK29x may want to know this as well. I'll ping him on discord after I post this.
Brazilian Ice Hockey League

Let me know if you have any issues accessing it

This is not unique to creating new leagues, as I fiddled around with this when making GUH and got it working, but wondering if there's some behind the scenes things with UID that comes into play. I've tried using the UID validator in other cases, and it usually doesn't make a difference to this behavior

I included both databases, which should be identical in setup. Both leagues run and can sim without any issues. The issue is with the menu navigation.
Brazil BrokenMenu, Brazilian Ice Hockey League = 1246683
Clicking the top Trophy Icon, Brings you to the Overview screen (most working leagues bring you to standings)
On a team page, clicking the BIHL does nothing (other working leagues bring you to standings page)

Brazilian_NewUID, I renamed an existing extinct league (I kept the name and added ID in long name just for quick reference, but that is just cosmetic)= Brazilian Ice Hockey League (11214 - Alpen League)
I updated the teams to point to the new LeagueID and updated the stages, finance, rules, and transfer rules to point to the existing new ID.

Otherwise everything should be configured exactly the same.

Clicking Trophy Icon brings you to standings
Clicking BIHL from team page brings you to standings

The game and sim works fine, just the weird menu issue.

I've been taking a look at this but cannot see anything obvious which would cause this issue. I'll send this to Riz tomorrow in case he is able to diagnose it.

[ideawithoutamind]

I've been taking a look at this but cannot see anything obvious which would cause this issue. I'll send this to Riz tomorrow in case he is able to diagnose it.

Thanks for looking into this! I've definitely experienced this when testing/creating new leagues, but usually can resolve by replacing an existing extinct/teamless league (usually with a lower UID), but would definitely be nice to know how to resolve without overwriting old leagues.

Appreciate all your work on all of this!

[ideawithoutamind]

A few quick notes, no rush again, and def can wait for 2.0, just leaving for documentation:

Competitions>Stages>Structure: Add Duplicate Stage (create next)
Competitions>Stages>Schedule Dates: Copy/paste line

People > Awards > Button to select and add add a group of batch awards (per league), best player, best in each position , best rookie most points, most goals, mvp, first all star team

Quick navigation from various tabs:
Club: Home City, select > add/edit city quick link
Club Arena, select > add/edit arena quick link

Read only:
Club: League , view classification, league rep, division, age limit (perhaps even in just a hover text box)
Club: Arena, view city, ice quality, rink size and capacities (perhaps also just a hover text box)

Clubs, Club Competitions> Colours: Randomize button (fun for created teams/leagues, just to add variety without too much thought)


Save game, viewing (not editing) questions:
Is there a way to export all in game stats/league/draft histories at a given point? (or is the location within the save file not known at the moment?)

External question:
This might not be an editor request exactly, but a batch save game exporter/option? Good for researching, let's say 10 .sav files (uncompressed), select the leagues or just all players, and have a batch export export of xlsx files of players (or if a command line prompt / bat file could accomplish the same?)

[archibalduk]

A few quick notes, no rush again, and def can wait for 2.0, just leaving for documentation:

Thanks! This is super helpful. I use this thread as a to-do list, so this is all very useful.

Save game, viewing (not editing) questions:
Is there a way to export all in game stats/league/draft histories at a given point? (or is the location within the save file not known at the moment?)

Unfortunately it is as you say; I don't know how to decode the tables. If I ever find the time then I could take another look but my task list is huge!

External question:
This might not be an editor request exactly, but a batch save game exporter/option? Good for researching, let's say 10 .sav files (uncompressed), select the leagues or just all players, and have a batch export export of xlsx files of players (or if a command line prompt / bat file could accomplish the same?)

I think this would probably require a completely separate tool. The Editor isn't setup to allow multiple files to be opened and closed due to the way in which the data models are initialised. This would be a pretty big project.

[xECK29x]

Hey Archi,

I'm starting to re-do and really use the Synonym files for clubs/comps, would it be possible to add comment support to those files? Would help me with organizing them.

EDIT: Also could there be a button to re-load the synonym files without requiring a save?

[archibalduk]

Sure, I can add both of those to the upcoming release.

[xECK29x]

What causes the import button to uncheck the use of those synonyms? I notice they just get unchecked for some reason.

[ideawithoutamind]

Related to the weird issue with the club competitions navigation issue, do you think there'd be a way to add a "swap" UID for club competitions (and have them swap the info in the record and any linked tables?

[ideawithoutamind]

Very Interesting bug/find, may not be an editor issue, but DB/game issue. This may also be worth checking if it loads into 1.5 differently, but I am able to recreate this one pretty easily. I can attach some examples if you want to see, but I was trying to adjust the financials so players salaries would load into the game at the start.

Everything else works, including the transfer settings and signing new contracts, so this is JUST the financial part of the start of the game. All of the Numbers of the financial INFO are the same for both.

Here is the behavior
Player A, Contracted to a Team in the League below yearly Salary = 12500000
Using the same for both attempts: League ID: 349, NEW NHL, UUID: 11349, Nation = USA
Financial ID: 69; assigned to League: 349 NEW NHL

Start game, (same results with both Disabled and uncheck Disable Finances)
Player A contact = 225000

Couldn't wrap my head around it, so I was poking around some old db (Namely BK's WHA and tried to mimic the finances there, because they were working)
*Player A is McDavid, but the same premise happens to guys making league minimum and in between. Usually most of the starting salaries are ~225, varying between teams, but none were above 1000000.

What I noticed was ID for the actual Finance Info was 1 for the WHA (not the league ID, but the ID for the financial info)

I then went back to my DB, found that the financial info ID 1 was assigned to an currently unused league. I then copied all the settings from the Financial ID 69: New NHL to the Financial ID = 1 record. I assigned the Financial ID = 69 to NONE, leaving it in the DB, then re-assigned Financial ID = 1 to point to the League ID 349 NEW NHL

Re-loaded the game, and voila. Player A contract now is 12500000.

I can send you a copy of both the working and the non-working finances, but I hope I described the behavior above. I think something is tied to the actual ID. I can re-create the issue, and resolve it, if you want me to send an example from a Fresh database. So what I am wondering are the ID's connected/hardcoded in the game to follow a certain set of rules per ID?

Side note: is there a reason why we cannot delete Financial Info records? Is it a corruption issue?

[archibalduk]

I think I'd need to see an example of each database (or screenshots of the relevant screens from the Editor) as I'm struggling to get my head around what you describe.

The Finance Info cannot be deleted simply because I haven't gotten around adding the function. I should really try to do that soon. Writing the Rules & Structures editing was a massive undertaking as I couldn't get a feel for how things connected together until I could get the data up and running in the editor; hence things like deletion were initially missed (and then forgotten!...)

[ideawithoutamind]

I think I'd need to see an example of each database (or screenshots of the relevant screens from the Editor) as I'm struggling to get my head around what you describe.

The Finance Info cannot be deleted simply because I haven't gotten around adding the function. I should really try to do that soon. Writing the Rules & Structures editing was a massive undertaking as I couldn't get a feel for how things connected together until I could get the data up and running in the editor; hence things like deletion were initially missed (and then forgotten!...)

Thanks! I just got around to recreating the issue and the fix. I uploaded them both here.
Broken Salaries ID 69 and Working Salaries ID 1
I used this one to recreated and show the bug, I used Pivot5.5 as my base, and just copied the NHL Club Competitions/divisions/conferences, and then NHL Clubs. Copied the appropriate Finance Info, Rules and Structure, Schedule Template, Transfer rules for the New NHL. Copied Rules and Structures and pointed all the league settings the appropriate sections to the new counterparts. Ran the league with empty teams, simmed, everything works. New contracts work, game sims. I didn't do a deep sim, was mostly loading to just check the salaries.

Under the hood, Financial ID = 1 is a duplicate financial record for Polska Hokej Liga, for the first set of screen shots, it's unchanged, I created a New Financial Info Record (ID=69) for the New NHL. I upload the dbs linked above, but just showing the issue and the fix.

Now here's the finance part:
For testing purposes, I moved Brent Burns and Rudolfs Balcers to the New San Jose Sharks in the New NHL from the regular SJ Sharks in the NHL.

Finance settings and screen shot of players in loaded game:


Incorrect salaries. Note the ID at the bottom of the screen shot.

To fix: I found the Financial ID =1, the Polska Hokej Liga duplicate record. Since another already existed, I just copied all the settings from the NHL into the Financial ID = 1. Changed the League to New NHL and Nation to USA. For Financial ID=69, I changed League and Nation both to [None]

Loaded the game up, and now the salaries are correct.


As I think you noted in other aspects of the game, I think IDs or ID ranges may be hardcoded for some things, I didn't test other ID's to see which work and which don't, but I have a feeling it's related. I was struggling to get the salaries working in the GUH db in an earlier version, and I have a feeling this is why.

[ideawithoutamind]

Small editor bug:
Nation import spreadsheet, League Standard does not update. Other fields work properly

[archibalduk]

Thanks very much. I'll take a look on Friday.

[archibalduk]

What causes the import button to uncheck the use of those synonyms? I notice they just get unchecked for some reason.

Sorry I missed this query the other day. I left it like this in case someone forgets to disable the settings after using them as inadvertently enabling those settings could cause unwanted side effects. This was probably too cautious because if you enable the settings, you should know what you're doing. I'll make the settings persist between sessions in the upcoming release.

[xECK29x]

Sorry I missed this query the other day. I left it like this in case someone forgets to disable the settings after using them as inadvertently enabling those settings could cause unwanted side effects. This was probably too cautious because if you enable the settings, you should know what you're doing. I'll make the settings persist between sessions in the upcoming release.

That makes sense and it's also why I didn't use them for so long as well, it could easily cause some pain if the file doesn't match the database. Maybe in the Settings menu on the editor have a global opt-in "use synonyms" box with a warning?

[archibalduk]

Sorry I missed this query the other day. I left it like this in case someone forgets to disable the settings after using them as inadvertently enabling those settings could cause unwanted side effects. This was probably too cautious because if you enable the settings, you should know what you're doing. I'll make the settings persist between sessions in the upcoming release.

That makes sense and it's also why I didn't use them for so long as well, it could easily cause some pain if the file doesn't match the database. Maybe in the Settings menu on the editor have a global opt-in "use synonyms" box with a warning?

That's a very good idea. I'll do that.

I'm aiming to have the Editor released today if I can but it's subject to how much time I have this evening. Just need to add the opt-in setting as well as allowing synonyms to be manually re-loaded.

I've added the ability to insert comment lines in the synonym files by putting two forward slashes at the front of the comment line like this:

Code: Select all

// THIS IS A COMMENT
glasgow clan,braehead clan

Blank lines are also acceptable.

[xECK29x]

Perfect thanks!