EHM 1 Database & Saved Game Editor v1: BUG REPORTS & FEATURE REQUESTS

[ideawithoutamind]

Sorry, I try to load my saved game in the editor and I cannot search for any players, teams, citys. It like its not loading the saved game database

2 things
1. make sure you are using the latest version of the editor, I was having some issues with earlier versions.
2. double check and make sure you do NOT have saved compressed checked in your EHM preferences.

Hope that helps!

[archibalduk]

Immensely appreciate your work on this, definitely none of these are NEEDS, but just giving my feedback!

Anyways those are just a few of my thoughts, happy to test or answer any additional questions if things aren't clear.

This is super helpful - thank you! There's some very good ideas here which I'm going to try to get into v2.x. Some of the simpler ones (e.g. importing names) I will try to get into v0.x/1.x.

Is the gmail address you have in your forum profile the best email address to get hold of you on? It's still a few months away, but I can send to you an alpha of v2.x at the right time if you're interested in trying it out. It'll only be read-only to start with (i.e. cannot save the database) just while I work on getting the league structure editing up and running, which I'm saving until last.

[ideawithoutamind]

Immensely appreciate your work on this, definitely none of these are NEEDS, but just giving my feedback!

Anyways those are just a few of my thoughts, happy to test or answer any additional questions if things aren't clear.

This is super helpful - thank you! There's some very good ideas here which I'm going to try to get into v2.x. Some of the simpler ones (e.g. importing names) I will try to get into v0.x/1.x.

Is the gmail address you have in your forum profile the best email address to get hold of you on? It's still a few months away, but I can send to you an alpha of v2.x at the right time if you're interested in trying it out. It'll only be read-only to start with (i.e. cannot save the database) just while I work on getting the league structure editing up and running, which I'm saving until last.

That email should get to me (although it's kind of a semi-junker email, so just give me a headsup via here, when you send it. Otherwise I'm on discord, if you use that platform).

Also on a side note, found one more little bug.
When exporting Teams, the Alt 1:Name and Alt 2:Name duplicate the DOB on the name field.
Ex. Alt 1: Name = Brad Marchand 2.7.1985 Alt:DOB=2.7.1985

Figured I'd throw it out there while I just spotted it.

[xECK29x]

Couple of asks for the Player Rights panel:

1) Add a flag for inactive clubs, or clubs that do not match the League assigned.
2) Add a flag for multiple entries with different clubs in the same league for a player.
3) Add DOB field and filter by year of birth (to assist in removing overage rights)
4) Add some form of multi-select or mass-edit option to update player rights.

[archibalduk]

Couple of asks for the Player Rights panel:

1) Add a flag for inactive clubs, or clubs that do not match the League assigned.
2) Add a flag for multiple entries with different clubs in the same league for a player.
3) Add DOB field and filter by year of birth (to assist in removing overage rights)
4) Add some form of multi-select or mass-edit option to update player rights.

I'll see what I can do for the next release. #4 might have to wait until Editor v2.x unless I can find a quick and easy way to do this in v0.x.

[ideawithoutamind]

One request feature for most sections (specifically, Club Competition, Clubs, Arenas), when clicking Add Item, could you populate the Long Name field with a unique name (possibly using the ID). Ex. Adding a new competition, creates a mostly blank record with the Long Name: New Club Competition 1234 (replace 1234 with ID of record), or other number default name. A bulk in-app option, (ie. add x amount of items with the numbered default names) would be nice, too, but simply automatically adding a name would be immensely useful as is.

This would help with creating /exporting / editing. I've found many times the IDs get a bit wonky if you are adding new rows in certain tables via spreaddsheet only, even after you use the validate UUID tool. Creating the rows in the editor, exporting and editing the spreadsheet leads to cleaner data inputs to the dbs.

Thanks!

[xECK29x]

I believe in an older build the jersey number was listed in the top information field when a staff member was selected, for example: 18 years old | Player | #39 | Ocelári Trinec U20.

Could this be added back? Was useful for spot checks

[TBIF]

Two things I was wondering Archi.

UI related, if a night/dark mode was possible? I do a ton of nighttime editing haha.

Would it be possible to export staff but only pull a single attribute? Just for saving time with export, very easy to work around though.

[xECK29x]

Not sure if it's been asked and on the roadmap but an export based on player rights per club, so if I wanted to export a players research sheet based on players with rights held by x team(s).

[xECK29x]

We also have come across a unique scenario where we may have found an issue where club IDs are required to be rotated due to crashing/other issues (related to my email this week about the Italian Hockey League in my DB). If we swap clubs out or create new ones and rename the old and move everything around the league works. I'd love for an advanced option to manually ad-hoc rotate or generate new UIDs for clubs/competitions if possible. This is something the Validate UIDs feature does not catch.

[archibalduk]

We also have come across a unique scenario where we may have found an issue where club IDs are required to be rotated due to crashing/other issues (related to my email this week about the Italian Hockey League in my DB). If we swap clubs out or create new ones and rename the old and move everything around the league works. I'd love for an advanced option to manually ad-hoc rotate or generate new UIDs for clubs/competitions if possible. This is something the Validate UIDs feature does not catch.

I'm not 100% sure I follow, but let me re-read your original email about the issue. If I cant get my head around it then I might ask you a couple of questions to clarify.

Just to check, are you looking to rotate Club IDs or just Club UIDs?

[xECK29x]

Just to check, are you looking to rotate Club IDs or just Club UIDs?

I believe it's the UID.

[archibalduk]

This is a weird one, and I'm not sure how it can be handled. We have a few cities where we use ',' in the longitude to get some divisions working properly. The ',' is not rendering properly on @Matee's editor, it always renders back as a '.'. Is this a localization issue? Matte is Polish and his Windows is set to Polish localization settings while I am on American English.

Sorry I missed this when originally posted. That's correct - it relates to the localisation settings of Matee's Windows.

[archibalduk]

This would help with creating /exporting / editing. I've found many times the IDs get a bit wonky if you are adding new rows in certain tables via spreaddsheet only, even after you use the validate UUID tool. Creating the rows in the editor, exporting and editing the spreadsheet leads to cleaner data inputs to the dbs.

Thanks!

Could you give an example of the steps to take in order to reproduce this ID issue?

[archibalduk]

Two things I was wondering Archi.

UI related, if a night/dark mode was possible? I do a ton of nighttime editing haha.

Yes, technically this is possible. You will need to create a shortcut to the EHM Editor.exe file, then right-click on the shortcut -> Properties -> Shortcut. In the "Target" field, add -platform windows:darkmode=2 immediately after the path as follows (note that this should be after the quotation marks and not within the quotation marks):

Code: Select all

"[YOUR PATH HERE]\EHM Editor.exe" -platform windows:darkmode=2

You will then need to go into the stylesheet.css file located in your EHM Editor folder and change the background and color settings to whatever colours you want. If you don't do this then you'll find a combination of dark and light colours in the Editor. Do backup your modified stylesheet.css file because it might get overwritten when you download future versions of the Editor. If you don't like your edits, you can just delete the css file and the Editor will create a new default copy when you next load the Editor.

I've done away with css styling for Editor v2.x, so the future Editor should be compatible with dark mode without needing to make any tweaks.

Would it be possible to export staff but only pull a single attribute? Just for saving time with export, very easy to work around though.

This would be a lot of work for v1.x Editor but it's on my list for v2.x.

[archibalduk]

Couple of asks for the Player Rights panel:

[...]

4) Add some form of multi-select or mass-edit option to update player rights.

What sort of editing are you looking to do here? Is it just to batch delete overaged players?

[xECK29x]

What sort of editing are you looking to do here? Is it just to batch delete overaged players?

Batch remove or update player rights, not just the removal of rights for overage players, that would be awesome if there was a Mass-Update tool for that though (remove player rights based on Max Age per competition )

[TBIF]

@archi

Anyway to get around certain DBs loading in with 1033 header in .4.7?

I guess to add to this, any DB that goes to open under 1033 header gets stuck at finance info

[archibalduk]

@archi

Anyway to get around certain DBs loading in with 1033 header in .4.7?

I guess to add to this, any DB that goes to open under 1033 header gets stuck at finance info

Yes, you need to apply this fix and then the DB should be fine to open in the Editor: viewtopic.php?f=148&t=20584

[TBIF]

Yes, you need to apply this fix and then the DB should be fine to open in the Editor: viewtopic.php?f=148&t=20584

Not sure how I missed that, thanks Archi!

[ideawithoutamind]

This would help with creating /exporting / editing. I've found many times the IDs get a bit wonky if you are adding new rows in certain tables via spreaddsheet only, even after you use the validate UUID tool. Creating the rows in the editor, exporting and editing the spreadsheet leads to cleaner data inputs to the dbs.

Thanks!

Could you give an example of the steps to take in order to reproduce this ID issue?

Sorry for the delay! I can send you some screenshots, but a simple re-creation in the club competition section (I think this happens in other tables as well)

Create a brand new league via editor GUI. League 0, Check UID: 1206474 (correct next number)
Import 3 leagues via spreadsheet.
League 1 UID: 1206475 (increased from the new league I made manually)
League 2 UID: 1206475 (same ID)
League 3 UID: 1206475 (same ID)
Will repeat no matter how many leagues you add.

Manually create a new league in GUI, League 4 UID: 1206475 (same as spreadsheet import UIDs)

Jump to teams, add a manual team: 1206476 (increments correctly, but now it's definitely way off sync)
Add (10 teams via spreadsheet), all UIDs: 1206477

I use the validator from time to time, but I think with all of the UID's being different at that point, it's really thrown off. I've started from scratch several times that way whenever things get wonky). Porting leagues from one db to another can be tedious, if I want to add batch leagues, teams, arenas, etc

My work around has been to create a bunch of incremental leagues manually via the GUI (or whichever table it is), incremental like league1, league2, league3, league4, so the editor manually adds the correct UID, then when i use the spreadsheet, I can just export, take the items I just created, and then rename/copy the data i wanted to the manually created IDs. ie. Export Clubs table. Filter everything except the new manually created items club1-40, fill in the New Long Name with the desired info and copy/paste everything else from the original spreadsheet I created.

[archibalduk]

Thanks - that's really helpful! I know what the source of the issue will be and it should be an easy fix.

The UID Validator will fix the issue in the meantime but you have to check and correct all references to clubs and leagues on the Leagues and Structure screen as a change in UID may cause some of these to go out of sync and this is why you might run into crashes etc.

[archibalduk]

This would help with creating /exporting / editing. I've found many times the IDs get a bit wonky if you are adding new rows in certain tables via spreaddsheet only, even after you use the validate UUID tool. Creating the rows in the editor, exporting and editing the spreadsheet leads to cleaner data inputs to the dbs.

Thanks!

Could you give an example of the steps to take in order to reproduce this ID issue?

Sorry for the delay! I can send you some screenshots, but a simple re-creation in the club competition section (I think this happens in other tables as well)

Create a brand new league via editor GUI. League 0, Check UID: 1206474 (correct next number)
Import 3 leagues via spreadsheet.
League 1 UID: 1206475 (increased from the new league I made manually)
League 2 UID: 1206475 (same ID)
League 3 UID: 1206475 (same ID)
Will repeat no matter how many leagues you add.

Manually create a new league in GUI, League 4 UID: 1206475 (same as spreadsheet import UIDs)

Jump to teams, add a manual team: 1206476 (increments correctly, but now it's definitely way off sync)
Add (10 teams via spreadsheet), all UIDs: 1206477

I use the validator from time to time, but I think with all of the UID's being different at that point, it's really thrown off. I've started from scratch several times that way whenever things get wonky). Porting leagues from one db to another can be tedious, if I want to add batch leagues, teams, arenas, etc

My work around has been to create a bunch of incremental leagues manually via the GUI (or whichever table it is), incremental like league1, league2, league3, league4, so the editor manually adds the correct UID, then when i use the spreadsheet, I can just export, take the items I just created, and then rename/copy the data i wanted to the manually created IDs. ie. Export Clubs table. Filter everything except the new manually created items club1-40, fill in the New Long Name with the desired info and copy/paste everything else from the original spreadsheet I created.

This is fixed for v0.4.9 which I'll be releasing in about 15 minutes. Thanks for spotting and reporting this.

[archibalduk]

Version 0.4.9 of the Editor is now available here: viewtopic.php?p=206841#p206841

A full changelist is set out at the end of this post. I was planning on adding some more features before release but the UID bug identified by ideawithoutamind above added some urgency to this release. The bug relates to importing data using spreadsheets which wasn't properly incrementing the UID tracker with each new item imported. So you'd end up with imported entries having duplicate UIDs. This bug is now fixed but you'll need to use the UID Validator to repair any existing duplicates.

Most of what is included with this release are feature requests from ideawithoutamind and xECK29x. There are additional requests which I haven't yet incorporated into the Editor but I hope to do so for the next release, subject to any other bugs/issues which might require a more urgent release.

The Editor now incorporates First Name and Second Name importing using spreadsheets and you can get the templates using the usual Import Spreadsheet -> Create Templates function. The template is very simple with just a 'Name' column and a 'Nation' column. Simply enter the text of the name and its nationality in the two columns. Any duplicate names will not be imported, so don't worry about importing names where you're not sure if they already exist in the database. A name is considered a duplicate of another if they are both spelled exactly the same (this is case sensitive) and the nation is the same. Names which are spelled the same but have different lowercase/uppercase letters are not considered duplicates - e.g. "da Costa" is not a duplicate of "Da Costa". One other thing to keep in mind is that the spreadsheets can only add names; it isn't possible to delete or edit names.

I'm now hosting the Editor on GitHub in addition to OneDrive (links can be found here). GitHub is a nice way of keeping a backup of each version with changelists, so I'm going to host the Editor there in addition to OneDrive. Unfortunately I cannot make the source code public, so the code remains on a separate private GitHub repository for now.

CHANGELIST: VERSION 0.4.9 (07-February-2021)

IMPORTANT! The Editor is now a 64-bit application and is now built using Microsoft Visual Studio C++ 2019. Consequently you must now install the Microsoft Visual Studio 2019 Redistributable before you attempt to run the Editor otherwise it will crash. You must install the 64-bit version (also known as vcredist_x64.exe). The Redistributable can be downloaded here: https://aka.ms/vs/16/release/VC_redist.x64.exe

New Features:

• First name and second name importing via the Import Spreadsheets function.

Fixes and Improvements:

• Added a sanity check when exporting .ehm files where invalid Transfer Rules ids have been set in the Editor;
• Added a filtered row count to the bottom of each editor screen;
• Added date of birth, status and duplicate count columns to the Player Rights editing screen;
• Added "[inactive]" to the end of club names in the editing screens and when importing non-research spreadsheets of players & staff and clubs;
• Added jersey number to the sub-heading on the Players & Staff editing screen;
• Auto-set Potential Ability function no longer modifies players with a zero Current Ability rating;
• Fixed a bug when exporting club research sheets where the date of birth of alternate captains would be listed twice;
• Fixed a bug when importing spreadsheets where the UID value would not be correctly incremented;
• Fixed a bug with senior and junior national teams being mixed up when importing spreadsheets;
• Jersey numbers are now initialised with zero (instead of -1) as the default value;
• Pass Tendency calculation can now be accessed via the Tools menu when viewing a player and via People -> Players & Staff -> Mass Edit; and
• The UID validator now re-numbers all club UIDs and assigns CHL-specific UIDs to clubs with a continental licence.

NOTE: Version 0.4.8 was an internal release. The above changelist includes changes incorporated in version 0.4.8.

[xECK29x]

Hey Archi I noticed this in the log when running the validator against the main working copy of the DB, is this something we should be concerned about? I assume it means just allocate licenses to 7 more clubs?

15:14:14: "WARNING: Insufficient clubs either (i) with a Continental License or (ii) being a Professional Swedish club for the purposes of allocating CHL-specific uids (7 additional clubs required)."