EHM 1 Database & Saved Game Editor v1: BUG REPORTS & FEATURE REQUESTS

[xECK29x]

Small and stupid bug I found, if you load a players/staff sheet where you are attemping to add a player/staff who is set to _retired it causes a crash.

[archibalduk]

Thanks, I'll take a look as soon as I've finished my current task on Editor v2.

[xECK29x]

Also it looks like EP made a change to the way goalie data is presented, they added a space to any value over 1000 for minutes and saves, can we have the editor ignore spaces in the import sheet for career history on the goalie specific fields? Would save us an extra step when we do bulk grabs and imports.

[xECK29x]

Bug found (guessing linked to club IDs and filters:

1) Create a filter to sort players/staff on a specific team
2) Add a new team via copy
3) Filters under players/staff screen are no longer correct, no longer able to create an accurate filter session per team unless you close and re-open the editor (example filtering on Arizona Coyotes show Philadelphia Flyers contracts).

[xECK29x]

Is there any way to clear all staff award history or mass delete rows via an import sheet?

[archibalduk]

Also it looks like EP made a change to the way goalie data is presented, they added a space to any value over 1000 for minutes and saves, can we have the editor ignore spaces in the import sheet for career history on the goalie specific fields? Would save us an extra step when we do bulk grabs and imports.

I'll have to have a think about this. There's two issues with this: (i) Simply removing spaces will also impact text strings (i.e. they'll lose spaces too) and (ii) I don't have much control over xlsx files as I use a third party plug-in for this.

Is there any way to clear all staff award history or mass delete rows via an import sheet?

I'll need to check the code, but possibly not. It'll be easy enough to add a mass edit function though.

[archibalduk]

Bug found (guessing linked to club IDs and filters:

1) Create a filter to sort players/staff on a specific team
2) Add a new team via copy
3) Filters under players/staff screen are no longer correct, no longer able to create an accurate filter session per team unless you close and re-open the editor (example filtering on Arizona Coyotes show Philadelphia Flyers contracts).

I'm struggling to repeat this issue. Is there a particular team (and ideally also their Team ID) that you're using to copy? I tried following your steps above by copying a random team and the filter worked fine (both before and after copying the team).

[xECK29x]

I'm struggling to repeat this issue. Is there a particular team (and ideally also their Team ID) that you're using to copy? I tried following your steps above by copying a random team and the filter worked fine (both before and after copying the team).

Shoot me a message on Discord when you are around and we can do a screenshare.

[archibalduk]

Sure - I should have some spare time on Thursday and will message you.

[xECK29x]

In the Draft History screen it would be helpful to highlight duplicates or flag them as an error, specifically identifying multiple players with the same Overall number for a specific draft class year.

[archibalduk]

Do you mean being able to edit the synonym files whilst the DB is open or do you mean being able to select a custom location from which to load the synonym files? I can definitely do both for Editor v2. If it's straightforward then I can add one/both to Editor v1 too.

More so the later, I'd like a button to load a non-default synonym file and point to a different file of any type (Cities, Club, Comp) which would be used ONLY FOR THAT SESSION.

This is now possible in the upcoming version 1.1.7. When you click on File -> Refresh Synonyms, you will now be presented with this pop-up:



Checking the above checkbox will allow you to specify a separate folder containing your custom synonyms. If your chosen folder is missing a synonym file then the Editor will use the default file for that category instead. This means that you could just have say a "club.txt" synonym file in your custom folder and then the Editor will use the default club_comps, cities, etc synonyms in addition to your custom clubs file. Un-checking the box above will use all of the defaults instead.

[archibalduk]

Also it looks like EP made a change to the way goalie data is presented, they added a space to any value over 1000 for minutes and saves, can we have the editor ignore spaces in the import sheet for career history on the goalie specific fields? Would save us an extra step when we do bulk grabs and imports.

This is now possible in upcoming version 1.1.7 (e.g. "1 234" will be imported as "1234") but we will need to make sure that there are no unintended consequences. If you see any numbers not "sticking" when being entered or imported then let me know. It should be fine based on my testing but there's always the possibility of some obscure edge case somewhere.

[xECK29x]

Awesome stuff!

[archibalduk]

Here's a new version of the Editor: https://ehmtheblueline.com/editor

CHANGELIST: VERSION 1.1.7 (20-March-2022)

IMPORTANT! The Editor now uses the Microsoft Visual Studio 2022 Redistributable 64-bit version. Prior versions of the Editor used the 2019 Redistributable.

New Features:

• Added 'Players with Player Rights' spreadsheet via the Export Spreadsheets screen which exports a staff research sheet.

Fixes and Improvements:

• Added duplicate filtering to the Draft History screen (click on the Re-validate History button at the bottom of the screen to update the list of duplicates after making edits);
• Added option to make player/non-player a national team free agent via the right-click menu on the Clubs -> Player Rosters and Staff Rosters sub-screens;
• Added support for spaces in between digits when importing spreadsheets (e.g. "1 234" will be imported as "1234");
• Added the ability to clear all staff award history via the People -> Mass Edit menu;
• Added the ability to select/highlight rows in a table and delete that selection (e.g. player career history, player rights, draft history screens);
• Players with no position set will now have a position auto-set according to their Player Role when using (i) the 'Validate Player Positions' option on the Import Spreadsheet screen, (ii) the 'Synchronise Role and Position' button on the Players and Staff -> Player Details sub-screen and (iii)the 'Synchronise Role and Position' button on the 'Auto-Set Attributes' mass editor;
• Refresh Synonyms now allows for a temporary custom folder for alternative synonym files (with the default folder as a fall-back); and
• Restored old "Unrecognised value" options for Jobs when importing spreadsheets just for backwards compatibility with spreadsheets exported using older versions of the Editor.

[TBIF]

Under club names a default option to NOT import any clubs with National (senior) or National (U20) status.

This will stop the U20 U20 team stuff and speed up mass importing of clubs

[xECK29x]

Cross-posting from the GitHub Issues page.

Feature Request(s): New cleanup tools for duplicate career history entries

I'd love to be able to do is mass-replace team names if I happened to link the wrong item or made a change. I love how "Find and replace competitions" works and I'd like to expand this functionality to clubs.

I'd also like the simplicity of being able to add 'd' to a career history template to remove items. This allows me to pull down massive amounts of career history entries and easily mass-delete them as I would staff/players.

[archibalduk]

Apologies for being slow on the Editor 1. I've been putting in all the time I can into v2 to try and get all of the Editor screens done.

Feature Request(s): New cleanup tools for duplicate career history entries

Sure. What would you consider duplicate? Would this be where the year, reg season/play-off status, club and league are all the same?

I'd love to be able to do is mass-replace team names if I happened to link the wrong item or made a change. I love how "Find and replace competitions" works and I'd like to expand this functionality to clubs.

Sure, that's straightforward.

I'd also like the simplicity of being able to add 'd' to a career history template to remove items. This allows me to pull down massive amounts of career history entries and easily mass-delete them as I would staff/players.

I'm doing this from memory but there is a way of doing this already. IIRC you can enter the player name + DOB, year, reg season/play-off status, club and league of the existing entry and then in the GP column enter 0 (zero). The Editor will auto-delete entries with zero GP (zero GP entries wouldn't appear in-game anyway). Is this sufficiently simple or is it a bit cumbersome? I'm happy to add a column if this is easier for your workflow.

[xECK29x]

Sure. What would you consider duplicate? Would this be where the year, reg season/play-off status, club and league are all the same?

Right now its self-inflicted, I imported a bunch of history data without having my synonym file enabled which led to issues like this:

2009 Ontario Reign ECHL 72 10 25 133 21
2009 Manchester Monarchs ECHL 72 10 25 133 -21
2010 Ontario Reign ECHL 63 9 19 127 10
2010 Manchester Monarchs American Hockey League 5 0 0 6 0
2010 Ontario Reign American Hockey League 5 0 0 6 0
2010 Manchester Monarchs ECHL 63 10 18 127 -10

So I would want to remove the club that is in the DB but not active as the current club is linked via a historical club name (synonym).

I'm doing this from memory but there is a way of doing this already. IIRC you can enter the player name + DOB, year, reg season/play-off status, club and league of the existing entry and then in the GP column enter 0 (zero). The Editor will auto-delete entries with zero GP (zero GP entries wouldn't appear in-game anyway). Is this sufficiently simple or is it a bit cumbersome? I'm happy to add a column if this is easier for your workflow.

This works for me.

[archibalduk]

Sure. What would you consider duplicate? Would this be where the year, reg season/play-off status, club and league are all the same?

Right now its self-inflicted, I imported a bunch of history data without having my synonym file enabled which led to issues like this:

2009 Ontario Reign ECHL 72 10 25 133 21
2009 Manchester Monarchs ECHL 72 10 25 133 -21
2010 Ontario Reign ECHL 63 9 19 127 10
2010 Manchester Monarchs American Hockey League 5 0 0 6 0
2010 Ontario Reign American Hockey League 5 0 0 6 0
2010 Manchester Monarchs ECHL 63 10 18 127 -10

So I would want to remove the club that is in the DB but not active as the current club is linked via a historical club name (synonym).

Ah I see - that's all clear. I'll add those two functions and will then push as an update, so you can fix sooner rather than later.

[archibalduk]

Right now its self-inflicted, I imported a bunch of history data without having my synonym file enabled which led to issues like this:

2009 Ontario Reign ECHL 72 10 25 133 21
2009 Manchester Monarchs ECHL 72 10 25 133 -21
2010 Ontario Reign ECHL 63 9 19 127 10
2010 Manchester Monarchs American Hockey League 5 0 0 6 0
2010 Ontario Reign American Hockey League 5 0 0 6 0
2010 Manchester Monarchs ECHL 63 10 18 127 -10

So I would want to remove the club that is in the DB but not active as the current club is linked via a historical club name (synonym).

I've added the above but I wanted to check on the specific criteria. Do you want either: (i) where the club is inactive, the duplicate history entry is deleted or (ii) the entry is deleted only where the club is inactive and its name is a synonym of the club of the other duplicate record? So in your example above, this is how it would work according to options (i) and (ii):

Option (i):
- The duplicate Manchester Monarchs entries will be deleted regardless of whether or not "Manchester Monarchs" is set as a synonym of "Ontario Reign".

Option (ii)
- The duplicate Manchester Monarchs entries will only be deleted if "Manchester Monarchs" is set as a synonym of "Ontario Reign". If it is not a synonym then the duplicate entries will be retained.

[xECK29x]

Option (ii)
- The duplicate Manchester Monarchs entries will only be deleted if "Manchester Monarchs" is set as a synonym of "Ontario Reign". If it is not a synonym then the duplicate entries will be retained.

Let's try this option first, looks a little safer. If its not tied to a synonym then there is a good chance I want to keep that record. Also I would like a "preview" or test run option for this just to review results before executing the cleanup.

[xECK29x]

Archi I PMed you on Discord, I think I may have come across a bug related to a UID issue. While working on the real schedule template for the VHL I'm running into this bizarre issue where it's pulling the Tucson Roadrunners into the schedule but not the league. I think this is a UID issue as Tucson has a low number UID, it might even be 0.

[archibalduk]

Option (ii)
- The duplicate Manchester Monarchs entries will only be deleted if "Manchester Monarchs" is set as a synonym of "Ontario Reign". If it is not a synonym then the duplicate entries will be retained.

Let's try this option first, looks a little safer. If its not tied to a synonym then there is a good chance I want to keep that record. Also I would like a "preview" or test run option for this just to review results before executing the cleanup.

Ok thanks. I'll see if I can add a preview either this week or next weekend.

[archibalduk]

Here's a new version of the Editor: https://ehmtheblueline.com/editor

CHANGELIST: VERSION 1.1.8 (07-August-2022)

IMPORTANT! The Editor now uses the Microsoft Visual Studio 2022 Redistributable 64-bit version. Prior versions of the Editor used the 2019 Redistributable.

Fixes and Improvements:

• Added the ability to mass delete identical player career history where one entry relates to an inactive club and one entry relates to an active club (the inactive club entry will be deleted) via the People -> Mass Edit menu; and
• Added the option to find and replace club names in player career history via the People -> Mass Edit menu.

xECK29x - Two things to note on the duplicate career history deletion are:

1. The Editor will delete the duplicate histories immediately but will also output a spreadsheet showing what entries were deleted. I recommend you save the database immediately before you run the deletion in case you're not happy with what has been deleted; and
2. I thought I'd try widening the net first without synonyms to see what other duplicates it brings up. If this is bringing up false positives then let me know and I'll add the synonym requirement we discussed before (the code is there; it's just disabled for the purposes of this first run).

[xECK29x]

Thanks Archi! Will test this out tomorrow!